Commons:User scripts/users namespace/reports/User:Brian/monobook.js
This is the report page for User:Brian/monobook.js. It is bot-maintained. All manual changes might be overwritten.
jshint edit
- ISSUE:
line 31 character 14
: Use '===' to compare with ''. - Evidence:if (target == '')
- ISSUE:
line 100 character 31
: Use '===' to compare with '0'. - Evidence:if (title.indexOf('Image:') == 0)
- ISSUE:
line 102 character 35
: Use '===' to compare with '0'. - Evidence:else if (title.indexOf('User:') == 0
- ISSUE:
line 103 character 38
: Use '===' to compare with '0'. - Evidence:|| title.indexOf('User_talk:') == 0)
- ISSUE:
line 105 character 40
: Use '===' to compare with '0'. - Evidence:else if (title.indexOf('Block_user') == 0) // could stand to be more robust
- ISSUE:
line 146 character 16
: eval can be harmful. - Evidence:var info = eval('(' + req.responseText + ')');
- ISSUE:
line 147 character 25
: ['query'] is better written in dot notation. - Evidence:for (var key in info['query']['pages'])
- ISSUE:
line 147 character 34
: ['pages'] is better written in dot notation. - Evidence:for (var key in info['query']['pages'])
- ISSUE:
line 149 character 24
: ['query'] is better written in dot notation. - Evidence:var page = info['query']['pages'][key];
- ISSUE:
line 149 character 33
: ['pages'] is better written in dot notation. - Evidence:var page = info['query']['pages'][key];
- ISSUE:
line 150 character 25
: ['edittoken'] is better written in dot notation. - Evidence:var token = page['edittoken'];
- ISSUE:
line 151 character 27
: ['revisions'] is better written in dot notation. - Evidence:var content = page['revisions'][0]['*'];
- ISSUE:
line 152 character 28
: ['revisions'] is better written in dot notation. - Evidence:var editTime = page['revisions'][0]['timestamp'].replace(/[^0-9]/g, '');
- ISSUE:
line 152 character 44
: ['timestamp'] is better written in dot notation. - Evidence:var editTime = page['revisions'][0]['timestamp'].replace(/[^0-9]/g, '');
- ISSUE:
line 189 character 9
: document.write can be a form of eval. - Evidence:document.write(req.responseText);
- ISSUE:
line 205 character 57
: Script URL. - Evidence:a.setAttribute('href', 'javascript:void(OTRS())');