Commons:User scripts/users namespace/reports/User:DieBuche/delete.js

This is the report page for User:DieBuche/delete.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 23 character 15: Bad or unnecessary escaping. - Evidence: 'tag': '{\{subst:nsd}}',
2. ISSUE: line 24 character 20: Bad or unnecessary escaping. - Evidence: 'talk_tag': '{\{subst:image source|1=%FILE%}}',
3. ISSUE: line 32 character 15: Bad or unnecessary escaping. - Evidence: 'tag': '{\{subst:npd}}',
4. ISSUE: line 33 character 20: Bad or unnecessary escaping. - Evidence: 'talk_tag': '{\{subst:image permission|1=%FILE%}}',
5. ISSUE: line 40 character 15: Bad or unnecessary escaping. - Evidence: 'tag': '{\{subst:nld}}',
6. ISSUE: line 41 character 20: Bad or unnecessary escaping. - Evidence: 'talk_tag': '{\{subst:image license|1=%FILE%}}',
7. ISSUE: line 69 character 87: Script URL. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.nominateForDeletion();',
8. ISSUE: line 72 character 84: Script URL. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.nominateForDeletion();',
9. ISSUE: line 79 character 90: Script URL. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
10. ISSUE: line 79 character 96: ['tag'] is better written in dot notation. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
11. ISSUE: line 79 character 117: ['img_summary'] is better written in dot notation. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
12. ISSUE: line 79 character 146: ['talk_tag'] is better written in dot notation. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
13. ISSUE: line 79 character 172: ['talk_summary'] is better written in dot notation. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
14. ISSUE: line 79 character 201: ['label'] is better written in dot notation. - Evidence: mw.util.addPortletLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
15. ISSUE: line 82 character 87: Script URL. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
16. ISSUE: line 82 character 93: ['tag'] is better written in dot notation. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
17. ISSUE: line 82 character 114: ['img_summary'] is better written in dot notation. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
18. ISSUE: line 82 character 143: ['talk_tag'] is better written in dot notation. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
19. ISSUE: line 82 character 169: ['talk_summary'] is better written in dot notation. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
20. ISSUE: line 82 character 198: ['label'] is better written in dot notation. - Evidence: addToolLink('p-tb', 'javascript:AjaxQuickDelete.insertTagOnPage("' + inb['tag'] + '","' + inb['img_summary'] + '","' + inb['talk_tag'] + '","' + inb['talk_summary'] + '");', inb['label']);
21. ISSUE: line 288 character 26: 'page' is already defined. - Evidence: var page = this.pages[ this.userTalkPrefix + user ];
22. ISSUE: line 301 character 36: Use '===' to compare with '0'. - Evidence: if (this.uploadersToNotify == 0) this.nextTask();
23. ISSUE: line 306 character 36: Use '===' to compare with '0'. - Evidence: if (this.uploadersToNotify == 0) this.nextTask();
24. ISSUE: line 355 character 33: 'pages' is already defined. - Evidence: if (this.tag) var pages = [ wgPageName ];
25. ISSUE: line 434 character 30: eval can be harmful. - Evidence: var result = eval( "(" + x.responseText + ")" );
26. ISSUE: line 438 character 18: 'result' used out of scope. - Evidence: if (!result) return o.fail( "Receive empty API response:\n" + x.responseText );
27. ISSUE: line 439 character 17: 'result' used out of scope. - Evidence: if (result.error) return o.fail( "API request failed (" + result.error.code + "): " + result.error.info );
28. ISSUE: line 439 character 71: 'result' used out of scope. - Evidence: if (result.error) return o.fail( "API request failed (" + result.error.code + "): " + result.error.info );
29. ISSUE: line 439 character 99: 'result' used out of scope. - Evidence: if (result.error) return o.fail( "API request failed (" + result.error.code + "): " + result.error.info );
30. ISSUE: line 440 character 31: 'result' used out of scope. - Evidence: try { o[callback](result); } catch (e) { return o.fail(e); }