Wikimedia Commons

Commons:User scripts/users namespace/reports/User:Erik Baas/HotCat.js

< Commons:User scripts‎ | users namespace/reports

This is the report page for User:Erik Baas/HotCat.js. It is bot-maintained. All manual changes might be overwritten.

jshint edit

  1. ISSUE: line 39 character 69: Use '===' to compare with 'null'. - Evidence: if ( wgNamespaceNumber != -1 || wgTitle != "Upload" || wgUserName == null) return ;
  2. ISSUE: line 43 character 10: Use '===' to compare with 'null'. - Evidence: if (ip == null) return;
  3. ISSUE: line 62 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null)
  4. ISSUE: line 102 character 13: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_ok ();
  5. ISSUE: line 108 character 19: eval can be harmful. - Evidence: do_submit = eval (hotcat_old_onsubmit);
  6. ISSUE: line 121 character 21: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
  7. ISSUE: line 121 character 23: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
  8. ISSUE: line 121 character 43: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
  9. ISSUE: line 121 character 45: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
  10. ISSUE: line 136 character 52: Use '!==' to compare with 'null'. - Evidence: if( document.getElementById('ca-viewsource' ) != null // User has no permission to edit
  11. ISSUE: line 150 character 20: Use '===' to compare with 'null'. - Evidence: if (visible_cats == null) {
  12. ISSUE: line 153 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
  13. ISSUE: line 165 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
  14. ISSUE: line 185 character 43: Use '!==' to compare with 'null'. - Evidence: && UploadForm.previous_hotcat_state != null)
  15. ISSUE: line 201 character 2: Missing semicolon. - Evidence: }
  16. ISSUE: line 253 character 51: Script URL. - Evidence: modify_link.href = "javascript:hotcat_modify(\"" + mod_id + "\");" ;
  17. ISSUE: line 356 character 26: The array literal notation [] is preferable. - Evidence: var result = new Array ();
  18. ISSUE: line 358 character 51: Use '!==' to compare with 'null'. - Evidence: while ((curr_match = cat_regex.exec (wikitext)) != null) {
  19. ISSUE: line 372 character 27: The array literal notation [] is preferable. - Evidence: var summary = new Array () ;
  20. ISSUE: line 384 character 14: Use '!==' to compare with 'null'. - Evidence: if (cat_rm != null && cat_rm.length > 0) {
  21. ISSUE: line 386 character 36: Use '===' to compare with '0'. - Evidence: if (!matches || matches.length == 0) {
  22. ISSUE: line 394 character 19: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0 && matches[0].match.length > 1)
  23. ISSUE: line 417 character 15: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0) {
  24. ISSUE: line 418 character 17: 'matches' is already defined. - Evidence: var matches = hotcat_find_category (t, cat_add);
  25. ISSUE: line 424 character 17: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  26. ISSUE: line 424 character 19: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  27. ISSUE: line 424 character 52: Use '!==' to compare with 'null'. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  28. ISSUE: line 424 character 80: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  29. ISSUE: line 424 character 82: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  30. ISSUE: line 426 character 14: 't2' is already defined. - Evidence: var t2 = t.replace(hotcat_uncat_regex, ""); // Remove "uncat" templates
  31. ISSUE: line 459 character 45: Script URL. - Evidence: a_add.href = "javascript:hotcat_add_new()" ;
  32. ISSUE: line 497 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null || !label.data) return defaultText;
  33. ISSUE: line 517 character 15: Use '!==' to compare with 'null'. - Evidence: if (l != null)
  34. ISSUE: line 524 character 15: Use '!==' to compare with 'null'. - Evidence: if (l != null)
  35. ISSUE: line 541 character 89: ['HotCatDelay'] is better written in dot notation. - Evidence: text.onkeyup = function () { window.setTimeout("hotcat_text_changed();", JSconfig.keys['HotCatDelay'] ); } ;
  36. ISSUE: line 541 character 38: Implied eval. Consider passing a function instead of a string. - Evidence: text.onkeyup = function () { window.setTimeout("hotcat_text_changed();", JSconfig.keys['HotCatDelay'] ); } ;
  37. ISSUE: line 560 character 12: Use '!==' to compare with 'null'. - Evidence: if (list != null) form.appendChild ( list ) ;
  38. ISSUE: line 562 character 14: Use '!==' to compare with 'null'. - Evidence: if (exists != null) form.appendChild ( exists ) ;
  39. ISSUE: line 585 character 15: Use '===' to compare with 'null'. - Evidence: if (request == null) {
  40. ISSUE: line 599 character 25: eval can be harmful. - Evidence: var do_submit = eval (request.responseText);
  41. ISSUE: line 604 character 53: Bad or unnecessary escaping. - Evidence: ,(txt && txt.value != v) ? " (redirect \[\[:Category:" + v + "|" + v + "\]\] resolved)" : null
  42. ISSUE: line 604 character 55: Bad or unnecessary escaping. - Evidence: ,(txt && txt.value != v) ? " (redirect \[\[:Category:" + v + "|" + v + "\]\] resolved)" : null
  43. ISSUE: line 604 character 86: Bad or unnecessary escaping. - Evidence: ,(txt && txt.value != v) ? " (redirect \[\[:Category:" + v + "|" + v + "\]\] resolved)" : null
  44. ISSUE: line 604 character 88: Bad or unnecessary escaping. - Evidence: ,(txt && txt.value != v) ? " (redirect \[\[:Category:" + v + "|" + v + "\]\] resolved)" : null
  45. ISSUE: line 623 character 26: ['title'] is better written in dot notation. - Evidence: var cat = cats[c]["title"];
  46. ISSUE: line 634 character 28: The array literal notation [] is preferable. - Evidence: var titles = new Array ();
  47. ISSUE: line 636 character 20: ['ns'] is better written in dot notation. - Evidence: if ( lks[i]["ns"] == 14 // Category namespace
  48. ISSUE: line 637 character 20: ['title'] is better written in dot notation. - Evidence: && lks[i]["title"] && lks[i]["title"].length > 0) { // Name not empty
  49. ISSUE: line 637 character 39: ['title'] is better written in dot notation. - Evidence: && lks[i]["title"] && lks[i]["title"].length > 0) { // Name not empty
  50. ISSUE: line 639 character 27: ['title'] is better written in dot notation. - Evidence: var match = lks[i]["title"];
  51. ISSUE: line 639 character 27: Too many errors. (67% scanned). - Evidence: undefined
Retrieved from "https://commons.wikimedia.org/w/index.php?title=Commons:User_scripts/users_namespace/reports/User:Erik_Baas/HotCat.js&oldid=460338361"