Commons:User scripts/users namespace/reports/User:Essjay~commonswiki/monobook.js

This is the report page for User:Essjay~commonswiki/monobook.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 71 character 15: Implied eval. Consider passing a function instead of a string. - Evidence: timerID = setTimeout('showtime()', 100);
2. ISSUE: line 98 character 14: Use '===' to compare with ''. - Evidence: if (target == '')
3. ISSUE: line 156 character 35: Use '===' to compare with '0'. - Evidence: if(document.title.indexOf("User") == 0)
4. ISSUE: line 254 character 43: Use '===' to compare with '0'. - Evidence: if (document.title.indexOf('Block user') == 0) // could stand to be more robust
5. ISSUE: line 266 character 5: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function SoFixItInit() // pre-load, (don't want to slow down loading of article's content, though)
6. ISSUE: line 271 character 5: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function SoFixItLoad() // post-load
7. ISSUE: line 338 character 5: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function PortletMenu( id ) // constructor
8. ISSUE: line 363 character 10: Missing semicolon. - Evidence: }
9. ISSUE: line 367 character 10: Missing semicolon. - Evidence: }
10. ISSUE: line 371 character 10: Missing semicolon. - Evidence: }
11. ISSUE: line 376 character 114: Missing semicolon. - Evidence: this.getText = function( id ) { return this[ id ].getElementsByTagName( 'a' )[ 0 ].firstChild.data }
12. ISSUE: line 377 character 120: Missing semicolon. - Evidence: this.setText = function( id, txt ) { this[ id ].getElementsByTagName( 'a' )[ 0 ].firstChild.data = txt }
13. ISSUE: line 379 character 109: Missing semicolon. - Evidence: this.getHref = function( id ) { return this[ id ].getElementsByTagName( 'a' )[ 0 ].href }
14. ISSUE: line 380 character 109: Missing semicolon. - Evidence: this.setHref = function( id, url ) { this[ id ].getElementsByTagName( 'a' )[ 0 ].href = url }
15. ISSUE: line 385 character 5: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function RemoveNode( id )
16. ISSUE: line 386 character 50: Missing semicolon. - Evidence: { var node = document.getElementById( id )
17. ISSUE: line 463 character 3: document.write can be a form of eval. - Evidence: document.writeln(lt+'script type="text/javascript" src="/w/index.php?title='+file+'&action=raw&ctype=text/javascript&dontcountme=s"'+gt+lt+'/script'+gt);
18. ISSUE: line 470 character 1: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="'
19. ISSUE: line 518 character 49: Expected a conditional expression and instead saw an assignment. - Evidence: if (matches = re.exec(document.location)) {
20. ISSUE: line 525 character 6: Unnecessary semicolon. - Evidence: };
21. ISSUE: line 1 character 11: Missing semicolon. - Evidence: showtime()