Commons:User scripts/users namespace/reports/User:Gunnex/monobook.js

This is the report page for User:Gunnex/monobook.js. It is bot-maintained. All manual changes might be overwritten.

jshint edit

  1. ISSUE: line 19 character 2: Missing semicolon. - Evidence: }
  2. ISSUE: line 106 character 61: Missing semicolon. - Evidence: w_ctrl = document.getElementById( JSconfig.prefix + key )
  3. ISSUE: line 130 character 18: Missing '()' invoking a constructor. - Evidence: var tabs = new Array;
  4. ISSUE: line 142 character 16: 'key' is already defined. - Evidence: for( var key in JSconfig.meta ) {
  5. ISSUE: line 146 character 84: Missing semicolon. - Evidence: w_label.appendChild( document.createTextNode( JSconfig.meta[key].description ) )
  6. ISSUE: line 173 character 2: Missing semicolon. - Evidence: }
  7. ISSUE: line 211 character 2: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="' + wgScript + '?title='
  8. ISSUE: line 228 character 43: Bad or unnecessary escaping. - Evidence: if (extraJS.match("^MediaWiki:[^&<>=%]*\.js$"))
  9. ISSUE: line 254 character 66: Missing semicolon. - Evidence: obj[type+fn] = function() { obj["e"+type+fn]( window.event ); }
  10. ISSUE: line 369 character 54: ['en'] is better written in dot notation. - Evidence: submit.value = sse_i18n[wgUserLanguage] || sse_i18n['en'];
  11. ISSUE: line 373 character 24: Use '===' to compare with ''. - Evidence: if(add_search_field == ""){
  12. ISSUE: line 378 character 4: Missing semicolon. - Evidence: }
  13. ISSUE: line 412 character 7: 'mainNode' used out of scope. - Evidence: if (!mainNode) return;
  14. ISSUE: line 413 character 2: 'mainNode' used out of scope. - Evidence: mainNode = mainNode[0];
  15. ISSUE: line 413 character 13: 'mainNode' used out of scope. - Evidence: mainNode = mainNode[0];
  16. ISSUE: line 414 character 2: 'mainNode' used out of scope. - Evidence: mainNode.appendChild(document.createElement("center"));
  17. ISSUE: line 415 character 2: 'mainNode' used out of scope. - Evidence: mainNode = mainNode.lastChild;
  18. ISSUE: line 415 character 13: 'mainNode' used out of scope. - Evidence: mainNode = mainNode.lastChild;
  19. ISSUE: line 422 character 2: 'mainNode' used out of scope. - Evidence: mainNode.appendChild(div);
  20. ISSUE: line 425 character 29: The object literal notation {} is preferable. - Evidence: var mayflowero = new Object();
  21. ISSUE: line 426 character 12: ['t'] is better written in dot notation. - Evidence: mayflowero["t"] = "n";
  22. ISSUE: line 451 character 21: ['UploadForm_loadform'] is better written in dot notation. - Evidence: if( !JSconfig.keys['UploadForm_loadform'] ) return;
  23. ISSUE: line 514 character 21: ['subPagesLink'] is better written in dot notation. - Evidence: if( !JSconfig.keys['subPagesLink'] ) return;
  24. ISSUE: line 523 character 77: ['en'] is better written in dot notation. - Evidence: var subpagesText = subPagesLink.i18n[wgUserLanguage] || subPagesLink.i18n['en'];
  25. ISSUE: line 529 character 2: Missing semicolon. - Evidence: }
  26. ISSUE: line 548 character 15: Missing '()' invoking a constructor. - Evidence: divs = new Array;
  27. ISSUE: line 551 character 15: 'j' is already defined. - Evidence: for (var j = 0; j < divs.length; j++)
  28. ISSUE: line 571 character 25: The object literal notation {} is preferable. - Evidence: var shufsets=new Object()
  29. ISSUE: line 571 character 27: Missing semicolon. - Evidence: var shufsets=new Object()
  30. ISSUE: line 572 character 54: Missing semicolon. - Evidence: var rx=new RegExp('dshuf'+'\\s+(dshufset\\d+)', 'i')
  31. ISSUE: line 573 character 47: Missing semicolon. - Evidence: var divs=document.getElementsByTagName("div")
  32. ISSUE: line 578 character 35: The object literal notation {} is preferable. - Evidence: shufsets[RegExp.$1]=new Object()
  33. ISSUE: line 578 character 37: Missing semicolon. - Evidence: shufsets[RegExp.$1]=new Object()
  34. ISSUE: line 579 character 33: Missing semicolon. - Evidence: shufsets[RegExp.$1].inner=[]
  35. ISSUE: line 580 character 34: Missing semicolon. - Evidence: shufsets[RegExp.$1].member=[]
  36. ISSUE: line 582 character 53: Missing semicolon. - Evidence: shufsets[RegExp.$1].inner.push(divs[i].innerHTML)
  37. ISSUE: line 583 character 44: Missing semicolon. - Evidence: shufsets[RegExp.$1].member.push(divs[i])
  38. ISSUE: line 586 character 7: Creating global 'for' variable. Should be 'for (var shufset ...'. - Evidence: for (shufset in shufsets){
  39. ISSUE: line 587 character 71: Don't make functions within a loop. - Evidence: shufsets[shufset].inner.sort(function() {return 0.5 - Math.random()})
  40. ISSUE: line 587 character 72: Missing semicolon. - Evidence: shufsets[shufset].inner.sort(function() {return 0.5 - Math.random()})
  41. ISSUE: line 588 character 13: 'i' is already defined. - Evidence: for (var i=0; i<shufsets[shufset].member.length; i++){
  42. ISSUE: line 589 character 68: Missing semicolon. - Evidence: shufsets[shufset].member[i].innerHTML=shufsets[shufset].inner[i]
  43. ISSUE: line 590 character 53: Missing semicolon. - Evidence: shufsets[shufset].member[i].style.display="block"