Commons:User scripts/users namespace/reports/User:Kelly/monobook.js

This is the report page for User:Kelly/monobook.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 1 character 1: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="'
2. ISSUE: line 11 character 2: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="'
3. ISSUE: line 15 character 2: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="/w/index.php?title=MediaWiki:Blanksearchextra.js&action=raw&ctype=text/javascript"><\/script>');
4. ISSUE: line 18 character 1: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="'
5. ISSUE: line 23 character 1: document.write can be a form of eval. - Evidence: document.write('<script type="text/javascript" src="'
6. ISSUE: line 64 character 69: Use '===' to compare with 'null'. - Evidence: if ( wgNamespaceNumber != -1 || wgTitle != "Upload" || wgUserName == null) return ;
7. ISSUE: line 68 character 10: Use '===' to compare with 'null'. - Evidence: if (ip == null) return;
8. ISSUE: line 87 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null)
9. ISSUE: line 127 character 13: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_ok ();
10. ISSUE: line 133 character 19: eval can be harmful. - Evidence: do_submit = eval (hotcat_old_onsubmit);
11. ISSUE: line 146 character 12: Use '===' to compare with ''. - Evidence: if ( t == "" || t.indexOf ('(+)') == 0 ) continue ;
12. ISSUE: line 146 character 39: Use '===' to compare with '0'. - Evidence: if ( t == "" || t.indexOf ('(+)') == 0 ) continue ;
13. ISSUE: line 147 character 21: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
14. ISSUE: line 147 character 23: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
15. ISSUE: line 147 character 43: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
16. ISSUE: line 147 character 45: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
17. ISSUE: line 162 character 52: Use '!==' to compare with 'null'. - Evidence: if( document.getElementById('ca-viewsource' ) != null // User has no permission to edit
18. ISSUE: line 176 character 20: Use '===' to compare with 'null'. - Evidence: if (visible_cats == null) {
19. ISSUE: line 179 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
20. ISSUE: line 191 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
21. ISSUE: line 211 character 43: Use '!==' to compare with 'null'. - Evidence: && UploadForm.previous_hotcat_state != null)
22. ISSUE: line 227 character 2: Missing semicolon. - Evidence: }
23. ISSUE: line 262 character 51: Script URL. - Evidence: modify_link.href = "javascript:hotcat_modify(\"" + mod_id + "\");" ;
24. ISSUE: line 364 character 26: The array literal notation [] is preferable. - Evidence: var result = new Array ();
25. ISSUE: line 366 character 51: Use '!==' to compare with 'null'. - Evidence: while ((curr_match = cat_regex.exec (wikitext)) != null) {
26. ISSUE: line 380 character 27: The array literal notation [] is preferable. - Evidence: var summary = new Array () ;
27. ISSUE: line 390 character 14: Use '!==' to compare with 'null'. - Evidence: if (cat_rm != null && cat_rm.length > 0) {
28. ISSUE: line 392 character 36: Use '===' to compare with '0'. - Evidence: if (!matches || matches.length == 0) {
29. ISSUE: line 400 character 19: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0 && matches[0].match.length > 1)
30. ISSUE: line 423 character 15: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0) {
31. ISSUE: line 424 character 17: 'matches' is already defined. - Evidence: var matches = hotcat_find_category (t, cat_add);
32. ISSUE: line 430 character 17: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
33. ISSUE: line 430 character 19: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
34. ISSUE: line 430 character 52: Use '!==' to compare with 'null'. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
35. ISSUE: line 430 character 80: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
36. ISSUE: line 430 character 82: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
37. ISSUE: line 432 character 14: 't2' is already defined. - Evidence: var t2 = t.replace(hotcat_uncat_regex, ""); // Remove "uncat" templates
38. ISSUE: line 466 character 45: Script URL. - Evidence: a_add.href = "javascript:hotcat_add_new()" ;
39. ISSUE: line 504 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null || !label.data) return defaultText;
40. ISSUE: line 524 character 15: Use '!==' to compare with 'null'. - Evidence: if (l != null)
41. ISSUE: line 531 character 15: Use '!==' to compare with 'null'. - Evidence: if (l != null)
42. ISSUE: line 548 character 89: ['HotCatDelay'] is better written in dot notation. - Evidence: text.onkeyup = function () { window.setTimeout("hotcat_text_changed();", JSconfig.keys['HotCatDelay'] ); } ;
43. ISSUE: line 548 character 38: Implied eval. Consider passing a function instead of a string. - Evidence: text.onkeyup = function () { window.setTimeout("hotcat_text_changed();", JSconfig.keys['HotCatDelay'] ); } ;
44. ISSUE: line 567 character 12: Use '!==' to compare with 'null'. - Evidence: if (list != null) form.appendChild ( list ) ;
45. ISSUE: line 569 character 14: Use '!==' to compare with 'null'. - Evidence: if (exists != null) form.appendChild ( exists ) ;
46. ISSUE: line 581 character 10: Use '===' to compare with ''. - Evidence: if ( v == "" ) {
47. ISSUE: line 649 character 14: Use '!==' to compare with 'null'. - Evidence: if (list != null) list.style.display = "none" ;
48. ISSUE: line 651 character 16: Use '!==' to compare with 'null'. - Evidence: if (exists != null) exists.style.display = "none" ;
49. ISSUE: line 658 character 10: Use '!==' to compare with ''. - Evidence: if ( v != "" ) {
50. ISSUE: line 663 character 17: Use '===' to compare with 'null'. - Evidence: if (request == null) {
51. ISSUE: line 663 character 17: Too many errors. (78% scanned). - Evidence: undefined