Commons:User scripts/users namespace/reports/User:Mahir256/subtitle-editor.js

This is the report page for User:Mahir256/subtitle-editor.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 232 character 53: Use '!==' to compare with '0'. - Evidence: if($(this).children('input').length != 0){
2. ISSUE: line 252 character 56: Use '!==' to compare with '0'. - Evidence: if($(this).children('textarea').length != 0){
3. ISSUE: line 256 character 31: 'inner' is already defined. - Evidence: var inner = $(this).children('textarea').val();
4. ISSUE: line 257 character 29: 'old' is already defined. - Evidence: var old = $(this).prop("old");
5. ISSUE: line 272 character 20: 'inner' used out of scope. - Evidence: if(inner === "" && $(this).hasClass("ll-list")){
6. ISSUE: line 339 character 79: Missing semicolon. - Evidence: table.buttons.prependTo($(this).find(".ll-col-index"))
7. ISSUE: line 398 character 18: Missing semicolon. - Evidence: }
8. ISSUE: line 399 character 101: Confusing plusses. - Evidence: startTime = startTime.replace(',','.').split(':').reduce((acc,time) => (60 * acc) + +time);
9. ISSUE: line 400 character 97: Confusing plusses. - Evidence: endTime = endTime.replace(',','.').split(':').reduce((acc,time) => (60 * acc) + +time);
10. ISSUE: line 552 character 19: Missing semicolon. - Evidence: })
11. ISSUE: line 579 character 19: Missing semicolon. - Evidence: })
12. ISSUE: line 596 character 23: Missing semicolon. - Evidence: })
13. ISSUE: line 635 character 46: Use '!==' to compare with '0'. - Evidence: if(data[index][key].type != 0){
14. ISSUE: line 647 character 18: Don't make functions within a loop. - Evidence: });
15. ISSUE: line 657 character 41: Use '!==' to compare with '0'. - Evidence: if(data[index].modified != 0){
16. ISSUE: line 661 character 50: Use '===' to compare with '0'. - Evidence: if(data[index][key].type == 0){
17. ISSUE: line 672 character 22: Don't make functions within a loop. - Evidence: });
18. ISSUE: line 711 character 78: Missing semicolon. - Evidence: $(".ll-preview-resume").prop("placeholder", "modified subtitles") // todo: reinsert some sort of summary
19. ISSUE: line 736 character 36: ['index'] is better written in dot notation. - Evidence: id: data[index]["index"].new,
20. ISSUE: line 737 character 43: ['startTime'] is better written in dot notation. - Evidence: startTime: data[index]["startTime"].new,
21. ISSUE: line 738 character 41: ['endTime'] is better written in dot notation. - Evidence: endTime: data[index]["endTime"].new,
22. ISSUE: line 739 character 38: ['text'] is better written in dot notation. - Evidence: text: data[index]["text"].new
23. ISSUE: line 745 character 39: ['query'] is better written in dot notation. - Evidence: return parser.fromSrt(data["query"]["pages"][0]["revisions"][0]["content"]);
24. ISSUE: line 745 character 48: ['pages'] is better written in dot notation. - Evidence: return parser.fromSrt(data["query"]["pages"][0]["revisions"][0]["content"]);
25. ISSUE: line 745 character 60: ['revisions'] is better written in dot notation. - Evidence: return parser.fromSrt(data["query"]["pages"][0]["revisions"][0]["content"]);
26. ISSUE: line 745 character 76: ['content'] is better written in dot notation. - Evidence: return parser.fromSrt(data["query"]["pages"][0]["revisions"][0]["content"]);
27. ISSUE: line 750 character 31: Use '===' to compare with '0'. - Evidence: if(this.lastrevid == 0){
28. ISSUE: line 769 character 28: ['edit'] is better written in dot notation. - Evidence: if(data["edit"].hasOwnProperty("result")){
29. ISSUE: line 800 character 43: ['query'] is better written in dot notation. - Evidence: model.lastrevid = data["query"]["pages"][0]["revisions"][0]["revid"];
30. ISSUE: line 800 character 52: ['pages'] is better written in dot notation. - Evidence: model.lastrevid = data["query"]["pages"][0]["revisions"][0]["revid"];
31. ISSUE: line 800 character 64: ['revisions'] is better written in dot notation. - Evidence: model.lastrevid = data["query"]["pages"][0]["revisions"][0]["revid"];
32. ISSUE: line 800 character 80: ['revid'] is better written in dot notation. - Evidence: model.lastrevid = data["query"]["pages"][0]["revisions"][0]["revid"];
33. ISSUE: line 825 character 19: Missing semicolon. - Evidence: size++
34. ISSUE: line 828 character 6: Unnecessary semicolon. - Evidence: };
35. ISSUE: line 923 character 12: 'portletLink' used out of scope. - Evidence: $( portletLink ).click( function () {
36. ISSUE: line 927 character 47: Missing semicolon. - Evidence: $(".ll-videopane").empty()
37. ISSUE: line 964 character 25: The object literal notation {} is preferable. - Evidence: var ret = new Object();

esprima

1. ERROR: Cannot parse line 399 column 84: Invalid left-hand side in assignment