Commons:User scripts/users namespace/reports/User:Ricordisamoa/FlagSense/unstable.js

This is the report page for User:Ricordisamoa/FlagSense/unstable.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 99 character 29: Creating global 'for' variable. Should be 'for (var s ...'. - Evidence: for(s in location.search.split("?")[1].split("&")){ // split the pairs
2. ISSUE: line 105 character 128: ['flagsense'] is better written in dot notation. - Evidence: if(document.getElementById("editform")&&((sessionStorage&&sessionStorage["FlagSense-currentAction"])||$_GET["flagsense"])){
3. ISSUE: line 113 character 37: ['flagsense'] is better written in dot notation. - Evidence: switch($_GET["flagsense"]?$_GET["flagsense"]:sessionStorage["FlagSense-currentAction"]){
4. ISSUE: line 113 character 56: ['flagsense'] is better written in dot notation. - Evidence: switch($_GET["flagsense"]?$_GET["flagsense"]:sessionStorage["FlagSense-currentAction"]){
5. ISSUE: line 119 character 51: ['VVA'] is better written in dot notation. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
6. ISSUE: line 119 character 72: Use '===' to compare with 'false'. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
7. ISSUE: line 122 character 89: Use '===' to compare with 'true'. - Evidence: else if(confirm(FlagSense.getMessage("vvaConfirmToSVG"))==true){ // ask for a confirmation
8. ISSUE: line 123 character 76: ['VVA'] is better written in dot notation. - Evidence: t.value=t.value.replace(FlagSense.regex["VVA"],template); // replace "Vector version available" with "Convert to SVG";
9. ISSUE: line 137 character 51: ['VVA'] is better written in dot notation. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
10. ISSUE: line 137 character 72: Use '===' to compare with 'false'. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
11. ISSUE: line 140 character 89: Use '===' to compare with 'true'. - Evidence: else if(confirm(FlagSense.getMessage("vvaConfirmToPNG"))==true){ // ask for a confirmation
12. ISSUE: line 141 character 76: ['VVA'] is better written in dot notation. - Evidence: t.value=t.value.replace(FlagSense.regex["VVA"],template); // replace "Vector version available" with "Convert to SVG";
13. ISSUE: line 158 character 59: ['VVA'] is better written in dot notation. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
14. ISSUE: line 158 character 80: Use '===' to compare with 'false'. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
15. ISSUE: line 161 character 95: Use '===' to compare with 'true'. - Evidence: else if(confirm(FlagSense.getMessage("vvaConfirmNew"))==true){ // ask for a confirmation
16. ISSUE: line 162 character 84: ['VVA'] is better written in dot notation. - Evidence: t.value=t.value.replace(FlagSense.regex["VVA"],template); // replace the old "Vector version available" with the new one;
17. ISSUE: line 183 character 59: ['VVA'] is better written in dot notation. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
18. ISSUE: line 183 character 80: Use '===' to compare with 'false'. - Evidence: if(FlagSense.regex["VVA"].test(t.value)==false){
19. ISSUE: line 186 character 97: Use '===' to compare with 'true'. - Evidence: else if(confirm(FlagSense.getMessage("vvaConfirmToPNG"))==true){ // ask for a confirmation
20. ISSUE: line 187 character 84: ['VVA'] is better written in dot notation. - Evidence: t.value=t.value.replace(FlagSense.regex["VVA"],template); // replace the old "Vector version available" with the new one;
21. ISSUE: line 202 character 98: ['cat'] is better written in dot notation. - Evidence: var cat=sessionStorage?sessionStorage["FlagSense-category"]:$_GET["cat"]; // category from sessionStorage or querystring
22. ISSUE: line 203 character 114: ['accuracy'] is better written in dot notation. - Evidence: var accuracy=parseFloat(sessionStorage?sessionStorage["FlagSense-accuracy"]:$_GET["accuracy"]); // category from sessionStorage or querystring
23. ISSUE: line 256 character 42: Use '!==' to compare with 'null'. - Evidence: (cat&&cat!=null&&wgCategories.indexOf(cat.cat)!=-1)?{
24. ISSUE: line 259 character 39: Use '===' to compare with 'null'. - Evidence: }:(cat==null?{
25. ISSUE: line 264 character 112: Use '===' to compare with 'true'. - Evidence: "title":"a category has been found"+(FlagSense.isCategorizedByAspectRatio()==true?" but the image is already categorized by aspect ratio":"")
26. ISSUE: line 268 character 40: Use '!==' to compare with 'null'. - Evidence: .append(cat!=null?$("<a>"+cat.ratio+"</a>").attr("href",mw.util.getUrl("Category:"+cat.cat)):ratio)
27. ISSUE: line 269 character 40: Use '!==' to compare with 'null'. - Evidence: .append(cat!=null?(" with"+(cat.accuracy>0?" an error of ±"+Math.round(cat.accuracy*100000)/100000:"out error")):"")
28. ISSUE: line 271 character 37: Use '!==' to compare with 'null'. - Evidence: (cat!=null&&wgCategories.indexOf(cat.cat)==-1)?$("<button>"+(FlagSense.isCategorizedByAspectRatio()==true?"Change category":"Add category")+"</button>")
29. ISSUE: line 271 character 132: Use '===' to compare with 'true'. - Evidence: (cat!=null&&wgCategories.indexOf(cat.cat)==-1)?$("<button>"+(FlagSense.isCategorizedByAspectRatio()==true?"Change category":"Add category")+"</button>")
30. ISSUE: line 322 character 38: Missing semicolon. - Evidence: }
31. ISSUE: line 331 character 66: ['toSVG'] is better written in dot notation. - Evidence: FlagSense.isTemplated(FlagSense.regex["toSVG"],function(result){
32. ISSUE: line 338 character 40: Missing semicolon. - Evidence: }))
33. ISSUE: line 342 character 66: ['VVA'] is better written in dot notation. - Evidence: FlagSense.isTemplated(FlagSense.regex["VVA"],function(result){
34. ISSUE: line 346 character 57: Missing semicolon. - Evidence: .append(" (change)")
35. ISSUE: line 352 character 66: ['toPNG'] is better written in dot notation. - Evidence: FlagSense.isTemplated(FlagSense.regex["toPNG"],function(result){
36. ISSUE: line 359 character 40: Missing semicolon. - Evidence: }))
37. ISSUE: line 363 character 66: ['ssPNG'] is better written in dot notation. - Evidence: FlagSense.isTemplated(FlagSense.regex["ssPNG"],function(result){
38. ISSUE: line 367 character 57: Missing semicolon. - Evidence: .append(" (change)")
39. ISSUE: line 388 character 21: Use '!==' to compare with 'null'. - Evidence: if(color!=null){
40. ISSUE: line 392 character 18: Don't make functions within a loop. - Evidence: });
41. ISSUE: line 393 character 33: Use '===' to compare with '0'. - Evidence: if(colors.length==0) colors.push([color,rgba]);
42. ISSUE: line 406 character 28: Use '===' to compare with '0'. - Evidence: else if(red==0) return "black";
43. ISSUE: line 410 character 22: Use '===' to compare with '0'. - Evidence: else if(alpha==0) return "transparent";
44. ISSUE: line 422 character 13: Creating global 'for' variable. Should be 'for (var r ...'. - Evidence: for(r in ratios){
45. ISSUE: line 426 character 24: A leading decimal point can be confused with a dot: '.04'. - Evidence: if(diff<.04) paragorns.push([ratios[r],diff]);
46. ISSUE: line 434 character 22: 'ratio' is already defined. - Evidence: var ratio=paragorn[0];
47. ISSUE: line 435 character 25: 'accuracy' is already defined. - Evidence: var accuracy=paragorn[1];
48. ISSUE: line 485 character 24: Use '!==' to compare with 'null'. - Evidence: if(category!=null&&accuracy!=null){
49. ISSUE: line 485 character 40: Use '!==' to compare with 'null'. - Evidence: if(category!=null&&accuracy!=null){
50. ISSUE: line 490 character 126: Use '!==' to compare with 'null'. - Evidence: document.location=$("li#ca-edit a").attr("href")+(!sessionStorage?"&flagsense="+action+((category&&accuracy&&category!=null&&accuracy!=null)?"&cat="+category+"&accuracy="+accuracy:""):""); // go to edit page
51. ISSUE: line 490 character 126: Too many errors. (95% scanned). - Evidence: undefined