Commons:User scripts/users namespace/reports/User:Rillke/CodeMirror/addon/merge/merge.js

This is the report page for User:Rillke/CodeMirror/addon/merge/merge.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 41 character 19: Missing 'new' prefix when invoking a constructor. - Evidence: this.orig = CodeMirror(pane, copyObj({value: orig, readOnly: !this.mv.options.allowEditingOriginals}, copyObj(options)));
2. ISSUE: line 108 character 32: 'change' is already defined. - Evidence: function change(_cm, change) {
3. ISSUE: line 141 character 35: Missing '()' invoking a constructor. - Evidence: var editor, other, now = +new Date;
4. ISSUE: line 152 character 26: A leading decimal point can be confused with a dot: '.5'. - Evidence: var halfScreen = .5 * sInfo.clientHeight, midY = sInfo.top + halfScreen;
5. ISSUE: line 173 character 32: 'targetPos' used out of scope. - Evidence: other.scrollTo(sInfo.left, targetPos);
6. ISSUE: line 181 character 13: Use '===' to compare with 'null'. - Evidence: if (bot == null) bot = editor.lastLine() + 1;
7. ISSUE: line 188 character 23: Use '!==' to compare with 'false'. - Evidence: if (val && action != false) syncScroll(dv, DIFF_INSERT) && makeConnections(dv);
8. ISSUE: line 230 character 15: Missing 'new' prefix when invoking a constructor. - Evidence: var pos = Pos(0, 0);
9. ISSUE: line 231 character 15: Missing 'new' prefix when invoking a constructor. - Evidence: var top = Pos(from, 0), bot = editor.clipPos(Pos(to - 1));
10. ISSUE: line 231 character 50: Missing 'new' prefix when invoking a constructor. - Evidence: var top = Pos(from, 0), bot = editor.clipPos(Pos(to - 1));
11. ISSUE: line 292 character 60: 'w' used out of scope. - Evidence: drawConnectorsForChunk(dv, ch, sTopOrig, sTopEdit, w);
12. ISSUE: line 315 character 18: 'i' is already defined. - Evidence: for (var i = 0; i < other.chunks.length; i++) {
13. ISSUE: line 316 character 19: 'chunk' is already defined. - Evidence: var chunk = other.chunks[i];
14. ISSUE: line 355 character 16: 'i' is already defined. - Evidence: for (var i = 0; i < cm.length; i++)
15. ISSUE: line 361 character 16: 'i' is already defined. - Evidence: for (var i = 0; i < cm.length; i++)
16. ISSUE: line 367 character 54: Use '!==' to compare with 'null'. - Evidence: for (var i = 0; i < cm.length; i++) if (lines[i] != null) {
17. ISSUE: line 372 character 16: 'i' is already defined. - Evidence: for (var i = 0; i < cm.length; i++) if (lines[i] != null) {
18. ISSUE: line 372 character 54: Use '!==' to compare with 'null'. - Evidence: for (var i = 0; i < cm.length; i++) if (lines[i] != null) {
19. ISSUE: line 400 character 27: 'tmp' is already defined. - Evidence: if (flip) { var tmp = botLpx; botLpx = botRpx; botRpx = tmp; }
20. ISSUE: line 430 character 35: Missing 'new' prefix when invoking a constructor. - Evidence: to.replaceRange(from.getRange(Pos(chunk.origFrom, 0), Pos(chunk.origTo, 0)),
21. ISSUE: line 430 character 59: Missing 'new' prefix when invoking a constructor. - Evidence: to.replaceRange(from.getRange(Pos(chunk.origFrom, 0), Pos(chunk.origTo, 0)),
22. ISSUE: line 431 character 26: Missing 'new' prefix when invoking a constructor. - Evidence: Pos(chunk.editFrom, 0), Pos(chunk.editTo, 0));
23. ISSUE: line 431 character 50: Missing 'new' prefix when invoking a constructor. - Evidence: Pos(chunk.editFrom, 0), Pos(chunk.editTo, 0));
24. ISSUE: line 440 character 68: Use '===' to compare with 'null'. - Evidence: var origLeft = options.origLeft, origRight = options.origRight == null ? options.orig : options.origRight;
25. ISSUE: line 442 character 28: Use '!==' to compare with 'null'. - Evidence: var hasLeft = origLeft != null, hasRight = origRight != null;
26. ISSUE: line 442 character 58: Use '!==' to compare with 'null'. - Evidence: var hasLeft = origLeft != null, hasRight = origRight != null;
27. ISSUE: line 464 character 17: 'rightPane' used out of scope. - Evidence: (hasRight ? rightPane : editPane).className += " CodeMirror-merge-pane-rightmost";
28. ISSUE: line 469 character 17: Missing 'new' prefix when invoking a constructor. - Evidence: this.edit = CodeMirror(editPane, copyObj(options));
29. ISSUE: line 471 character 25: 'leftPane' used out of scope. - Evidence: if (left) left.init(leftPane, origLeft, options);
30. ISSUE: line 472 character 27: 'rightPane' used out of scope. - Evidence: if (right) right.init(rightPane, origRight, options);
31. ISSUE: line 523 character 20: Did you mean to return a conditional instead of an assignment? - Evidence: return dv.gap = elt("div", gapElts, "CodeMirror-merge-gap");
32. ISSUE: line 550 character 17: A constructor name should start with an uppercase letter. - Evidence: var dmp = new diff_match_patch();
33. ISSUE: line 570 character 16: Missing 'new' prefix when invoking a constructor. - Evidence: var edit = Pos(0, 0), orig = Pos(0, 0);
34. ISSUE: line 570 character 34: Missing 'new' prefix when invoking a constructor. - Evidence: var edit = Pos(0, 0), orig = Pos(0, 0);
35. ISSUE: line 604 character 11: Use '===' to compare with '0'. - Evidence: if (i == 0) return true;
36. ISSUE: line 618 character 18: Use '===' to compare with 'null'. - Evidence: if (afterE == null) {
37. ISSUE: line 633 character 28: Missing 'new' prefix when invoking a constructor. - Evidence: var mark = cm.markText(Pos(from, 0), Pos(to - 1), {
38. ISSUE: line 633 character 42: Missing 'new' prefix when invoking a constructor. - Evidence: var mark = cm.markText(Pos(from, 0), Pos(to - 1), {
39. ISSUE: line 721 character 22: Missing 'new' prefix when invoking a constructor. - Evidence: var out = copy ? Pos(pos.line, pos.ch) : pos, at = 0;
40. ISSUE: line 760 character 15: Use '!==' to compare with 'null'. - Evidence: if (pos != null && (found == null || (dir < 0 ? pos > found : pos < found)))
41. ISSUE: line 760 character 33: Use '===' to compare with 'null'. - Evidence: if (pos != null && (found == null || (dir < 0 ? pos > found : pos < found)))
42. ISSUE: line 763 character 15: Use '!==' to compare with 'null'. - Evidence: if (found != null)