Commons:User scripts/users namespace/reports/User:Romanceor/monobook.js
This is the report page for User:Romanceor/monobook.js. It is bot-maintained. All manual changes might be overwritten.
jshint edit
- ISSUE:
line 7 character 1
: document.write can be a form of eval. - Evidence:document.write('<script type="text/javascript" src="'
- ISSUE:
line 29 character 21
: Use '===' to compare with ''. - Evidence:if( editbox.value == '' )
- ISSUE:
line 87 character 88
: Use '===' to compare with 'null'. - Evidence:if ( wgNamespaceNumber != -1 || wgCanonicalSpecialPageName != "Upload" || wgUserName == null) return ;
- ISSUE:
line 91 character 10
: Use '===' to compare with 'null'. - Evidence:if (ip == null) return;
- ISSUE:
line 115 character 13
: Use '===' to compare with 'null'. - Evidence:if (label == null)
- ISSUE:
line 155 character 13
: Use '!==' to compare with 'null'. - Evidence:if (input != null) hotcat_ok ();
- ISSUE:
line 161 character 19
: eval can be harmful. - Evidence:do_submit = eval (hotcat_old_onsubmit);
- ISSUE:
line 174 character 21
: Bad or unnecessary escaping. - Evidence:var new_cat = "\[\[Category:" + t + "\]\]" ;
- ISSUE:
line 174 character 23
: Bad or unnecessary escaping. - Evidence:var new_cat = "\[\[Category:" + t + "\]\]" ;
- ISSUE:
line 174 character 43
: Bad or unnecessary escaping. - Evidence:var new_cat = "\[\[Category:" + t + "\]\]" ;
- ISSUE:
line 174 character 45
: Bad or unnecessary escaping. - Evidence:var new_cat = "\[\[Category:" + t + "\]\]" ;
- ISSUE:
line 197 character 57
: Expected a 'break' statement before 'case'. - Evidence:container = document.getElementById ('quickbar');
- ISSUE:
line 211 character 52
: Use '!==' to compare with 'null'. - Evidence:return document.getElementById ('ca-edit') != null;
- ISSUE:
line 230 character 20
: Use '===' to compare with 'null'. - Evidence:if (visible_cats == null) {
- ISSUE:
line 233 character 21
: Use '===' to compare with 'null'. - Evidence:if (hidden_cats == null) {
- ISSUE:
line 245 character 21
: Use '===' to compare with 'null'. - Evidence:if (hidden_cats == null) {
- ISSUE:
line 266 character 43
: Use '!==' to compare with 'null'. - Evidence:&& UploadForm.previous_hotcat_state != null)
- ISSUE:
line 282 character 2
: Missing semicolon. - Evidence:}
- ISSUE:
line 314 character 31
: Use '!==' to compare with '0'. - Evidence:if (href.indexOf (prefix) != 0) prefix = wgServer + prefix; // Fully expanded URL?
- ISSUE:
line 315 character 31
: Use '===' to compare with '0'. - Evidence:if (href.indexOf (prefix) == 0) {
- ISSUE:
line 336 character 51
: Script URL. - Evidence:modify_link.href = "javascript:hotcat_modify(\"" + mod_id + "\");" ;
- ISSUE:
line 440 character 26
: The array literal notation [] is preferable. - Evidence:var result = new Array ();
- ISSUE:
line 442 character 51
: Use '!==' to compare with 'null'. - Evidence:while ((curr_match = cat_regex.exec (wikitext)) != null) {
- ISSUE:
line 457 character 27
: The array literal notation [] is preferable. - Evidence:var summary = new Array () ;
- ISSUE:
line 469 character 15
: Use '!==' to compare with 'null'. - Evidence:if (cat_key != null) cat_key = '|' + cat_key;
- ISSUE:
line 470 character 14
: Use '!==' to compare with 'null'. - Evidence:if (cat_rm != null && cat_rm.length > 0) {
- ISSUE:
line 472 character 36
: Use '===' to compare with '0'. - Evidence:if (!matches || matches.length == 0) {
- ISSUE:
line 480 character 19
: Use '!==' to compare with 'null'. - Evidence:if (cat_add != null && cat_add.length > 0 && matches[0].match.length > 1)
- ISSUE:
line 499 character 41
: Bad or unnecessary escaping. - Evidence:summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
- ISSUE:
line 499 character 43
: Bad or unnecessary escaping. - Evidence:summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
- ISSUE:
line 499 character 84
: Bad or unnecessary escaping. - Evidence:summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
- ISSUE:
line 499 character 86
: Bad or unnecessary escaping. - Evidence:summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
- ISSUE:
line 503 character 15
: Use '!==' to compare with 'null'. - Evidence:if (cat_add != null && cat_add.length > 0) {
- ISSUE:
line 504 character 17
: 'matches' is already defined. - Evidence:var matches = hotcat_find_category (t, cat_add);
- ISSUE:
line 510 character 17
: Bad or unnecessary escaping. - Evidence:t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
- ISSUE:
line 510 character 19
: Bad or unnecessary escaping. - Evidence:t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
- ISSUE:
line 510 character 52
: Use '!==' to compare with 'null'. - Evidence:t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
- ISSUE:
line 510 character 80
: Bad or unnecessary escaping. - Evidence:t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
- ISSUE:
line 510 character 82
: Bad or unnecessary escaping. - Evidence:t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
- ISSUE:
line 511 character 45
: Bad or unnecessary escaping. - Evidence:summary.push ("Quick-adding category \[\[:Category:" + cat_add + "|" + cat_add + "\]\]" + comment);
- ISSUE:
line 511 character 47
: Bad or unnecessary escaping. - Evidence:summary.push ("Quick-adding category \[\[:Category:" + cat_add + "|" + cat_add + "\]\]" + comment);
- ISSUE:
line 511 character 90
: Bad or unnecessary escaping. - Evidence:summary.push ("Quick-adding category \[\[:Category:" + cat_add + "|" + cat_add + "\]\]" + comment);
- ISSUE:
line 511 character 92
: Bad or unnecessary escaping. - Evidence:summary.push ("Quick-adding category \[\[:Category:" + cat_add + "|" + cat_add + "\]\]" + comment);
- ISSUE:
line 512 character 14
: 't2' is already defined. - Evidence:var t2 = t.replace(hotcat_uncat_regex, ""); // Remove "uncat" templates
- ISSUE:
line 546 character 45
: Script URL. - Evidence:a_add.href = "javascript:hotcat_add_new()" ;
- ISSUE:
line 584 character 13
: Use '===' to compare with 'null'. - Evidence:if (label == null || !label.data) return defaultText;
- ISSUE:
line 604 character 15
: Use '!==' to compare with 'null'. - Evidence:if (l != null)
- ISSUE:
line 611 character 15
: Use '!==' to compare with 'null'. - Evidence:if (l != null)
- ISSUE:
line 624 character 36
: ['HotCatEditBoxWidth'] is better written in dot notation. - Evidence:var default_width = JSconfig.keys['HotCatEditBoxWidth'];
- ISSUE:
line 633 character 66
: ['HotCatDelay'] is better written in dot notation. - Evidence:window.setTimeout ("hotcat_text_changed ();", JSconfig.keys['HotCatDelay']);
- ISSUE:
line 633 character 66
: Too many errors. (58% scanned). - Evidence:undefined