MediaWiki talk:Gadgets-definition/Archive/2021

Remove hard "jquery.ui" dependency from AjaxQuickDelete and Slideshow

The AjaxQuickDelete and Slideshow gadgets get loaded on all pages, including Special pages. Both of these gadgets list jquery.ui as a "hard" dependency here using the [ResourceLoader|dependencies=jquery.ui|default|type=general] format. As far as I can tell, this should not be necessary; both gadgets already treat the jquery.ui library as a "soft" dependency with mw.loader.using in their source code. I was able to determine that these two gadgets were loading jquery.ui on Commons special pages by using mw.inspect() and mw.inspect.getDependencyGraph() from my browser console.

jQuery UI is a large library (~350KB uncompressed). If we can avoid loading it in places where we aren't using it, some users would likely see a noticeable performance improvement.

My suggestion is to remove the jquery.ui dependency from these two gadget definitions. If something unexpected were to break, this change can be reverted and we could investigate further.

---EGardner (WMF) (talk) 23:21, 19 January 2021 (UTC)

@EGardner, Done! --Krinkle 22:51, 9 July 2021 (UTC)

Great, thanks! EGardner (WMF) (talk) 23:34, 13 July 2021 (UTC)

This section was archived on a request by: —‍Mdaniels5757 (talk • contribs) 12:31, 7 October 2022 (UTC)

switching off MediaWiki:Gadget-userRightsManager.js

{{Editprotected}} I propose switching this gadget off: it seems to be not maintained as @Mdaniels5757 isn't so active now. At the same time it has some issues described here: it is not always assigning rights as it is intended. I think there is some issue with tokens while performing API-action. rubin16 (talk) 15:56, 9 July 2021 (UTC)

No objections for more than a year and the presence of the gadget just results in confusions: User talk:Mdaniels5757#using MediaWiki:Gadget-userRightsManager.js rubin16 (talk) 08:37, 7 October 2022 (UTC)

 Done —‍Mdaniels5757 (talk • contribs) 12:30, 7 October 2022 (UTC)

This section was archived on a request by: —‍Mdaniels5757 (talk • contribs) 12:30, 7 October 2022 (UTC)

JS error in the Move & Replace function

@Krinkle Hi, I am not sure if your latest edits to MediaWiki:Gadgets-definition result into a new JS error in the Move & Replace function:

Uncaught TypeError: $(...).append(...).dialog is not a function

   jQuery

Could you check please? Thanks a lot. Raymond 09:10, 10 July 2021 (UTC)

@Raymond, Fixed in edit. --Krinkle (talk) 17:46, 10 July 2021 (UTC)

@Krinkle Thank's a lot. Move & replace works again. Raymond 17:52, 10 July 2021 (UTC)

This section was archived on a request by: —‍Mdaniels5757 (talk • contribs) 12:31, 7 October 2022 (UTC)