Open main menu

User talk:ESanders (WMF)

Active discussions

This is mostly impressive!Edit

  Here's a cookie for your excellent Pumpkipedia. Marcoil (talk) 16:44, 30 October 2013 (UTC)
Thanks, ESanders (WMF) (talk) 16:58, 30 October 2013 (UTC)

HotCatEdit

your recent changes broke hotcat when the user language is an RTL language.

please roll them back, and re-apply when they work for RTL too. many thanks, peace - קיפודנחש (talk) 16:29, 22 January 2017 (UTC)

Thanks, I made a follow up fix for the RTL code I modified. ESanders (WMF) (talk) 16:37, 22 January 2017 (UTC)
just came here to suggest that the change in line 2961 from if (is_rtl && is_ie6) return to if (is_rtl) return is surely incorrect.... peace - קיפודנחש (talk) 16:39, 22 January 2017 (UTC)


Code issues in MediaWiki:Gadget-HotCat.jsEdit

Hi ESanders (WMF), I am a bored bot (this is kind of a computer program) that is watching the recent changes and tapping buttons like I did now.

Curious about the reason? Possibly not but I will tell you anyway:

  1. You edited MediaWiki:Gadget-HotCat.js. Thank you for caring about Wikimedia Commons's javascript pages.
  2. Though, that change appears to introduce 25 new jshint issues — the page's status is now having warnings.
  3. To help you understanding where the issues are, I have aggregated a report here and now. If you have questions, don't hesitate to ask users experienced in javascript writing for help. But do not ask the bot's operators (chronically overwrought) unless you suspect an error of mine.
  1. ISSUE: line 128 character 44: ['creator'] is better written in dot notation. - Evidence: && ( ns === nsIds['creator']
  2. ISSUE: line 129 character 44: ['timedtext'] is better written in dot notation. - Evidence: || ns === nsIds['timedtext']
  3. ISSUE: line 130 character 44: ['institution'] is better written in dot notation. - Evidence: || ns === nsIds['institution']
  4. ISSUE: line 268 character 61: eval can be harmful. - Evidence: if (settings.success) settings.success (eval ('(' + req.responseText + ')'));
  5. ISSUE: line 409 character 9: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function autoLocalize (namespaceNumber, fallback) {
  6. ISSUE: line 1025 character 34: ['title'] is better written in dot notation. - Evidence: var cat = cats[c]['title'];
  7. ISSUE: line 1041 character 26: ['ns'] is better written in dot notation. - Evidence: if ( lks[i]['ns'] == 14 // Category namespace -- always true since we ask only for the category links
  8. ISSUE: line 1042 character 26: ['title'] is better written in dot notation. - Evidence: && lks[i]['title'] && lks[i]['title'].length > 0) // Name not empty
  9. ISSUE: line 1042 character 45: ['title'] is better written in dot notation. - Evidence: && lks[i]['title'] && lks[i]['title'].length > 0) // Name not empty
  10. ISSUE: line 1045 character 35: ['title'] is better written in dot notation. - Evidence: var match = lks[i]['title'];
  11. ISSUE: line 1719 character 56: Variables should not be deleted. - Evidence: window.setTimeout (function () {delete self;}, 10);
  12. ISSUE: line 1988 character 30: Variables should not be deleted. - Evidence: delete cb;
  13. ISSUE: line 2417 character 34: Expected a 'break' statement before 'case'. - Evidence: case UP: dir = -1;
  14. ISSUE: line 2418 character 50: Expected a 'break' statement before 'case'. - Evidence: case DOWN: if (dir === 0) dir = 1;
  15. ISSUE: line 2419 character 66: Expected a 'break' statement before 'case'. - Evidence: case PGUP: if (dir === 0) dir = -HotCat.list_size;
  16. ISSUE: line 2525 character 38: ['HotCatSuggestionDelay'] is better written in dot notation. - Evidence: || config['HotCatSuggestionDelay']
  17. ISSUE: line 2528 character 38: ['HotCatEditBoxWidth'] is better written in dot notation. - Evidence: || config['HotCatEditBoxWidth']
  18. ISSUE: line 2531 character 38: ['HotCatSuggestions'] is better written in dot notation. - Evidence: || config['HotCatSuggestions']
  19. ISSUE: line 2583 character 52: ['direction'] is better written in dot notation. - Evidence: is_rtl = document.body.currentStyle['direction'];
  20. ISSUE: line 2585 character 45: ['direction'] is better written in dot notation. - Evidence: is_rtl = document.body.style['direction'];
  21. ISSUE: line 2595 character 65: Expected a 'break' statement before 'case'. - Evidence: container = document.getElementById ('quickbar');
  22. ISSUE: line 2674 character 41: eval can be harmful. - Evidence: do_submit = eval (oldSubmit);
  23. ISSUE: line 3063 character 25: 'startHotCat' is already defined. - Evidence: var startHotCat = function() {
  24. ISSUE: line 3070 character 29: 'startHotCat' used out of scope. - Evidence: mw.loader.using('user', startHotCat, startHotCat);
  25. ISSUE: line 3070 character 42: 'startHotCat' used out of scope. - Evidence: mw.loader.using('user', startHotCat, startHotCat);

Your CommonsMaintenanceBot (talk) at 11:07, 24 May 2017 (UTC).

HotCat is brokenEdit

Hey, I don't know what your two edits to MediaWiki:Gadget-HotCat.js are supposed to do, but they broke HotCat for me. I now get this error in my JS console:

JavaScript parse error: Parse error: Unexpected token; token 3 expected in file 'MediaWiki:Gadget-HotCat.js' on line 2904

Could you please revert or otherwise correct the issue? Thanks, IagoQnsi (talk) 19:24, 2 August 2017 (UTC)


Code issues in MediaWiki:Gadget-ImageAnnotator.jsEdit

Hi ESanders (WMF), I am a bored bot (this is kind of a computer program) that is watching the recent changes and tapping buttons like I did now.

Curious about the reason? Possibly not but I will tell you anyway:

  1. You edited MediaWiki:Gadget-ImageAnnotator.js. Thank you for caring about Wikimedia Commons's javascript pages.
  2. Though, that change appears to introduce 7 new jshint issues — the page's status is now having warnings.
  3. To help you understanding where the issues are, I have aggregated a report here and now. If you have questions, don't hesitate to ask users experienced in javascript writing for help. But do not ask the bot's operators (chronically overwrought) unless you suspect an error of mine.
  1. ISSUE: line 435 character 39: Use '===' to compare with 'null'. - Evidence: if ( text == null ) { return ''; }
  2. ISSUE: line 738 character 52: Use '!==' to compare with 'null'. - Evidence: if ( self.note.content != null ) {
  3. ISSUE: line 1020 character 116: Don't make functions within a loop. - Evidence: !Array.exists( this.annotations, function ( note ) { return note.model.id == id; } )
  4. ISSUE: line 1036 character 65: Use '===' to compare with '0'. - Evidence: if ( !this.main_div || this.main_div.length == 0 ) { this.main_div = null; } else { this.main_div = this.main_div[ 0 ]; }
  5. ISSUE: line 1083 character 23: Don't make functions within a loop. - Evidence: } );
  6. ISSUE: line 1231 character 29: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function intersect_rectangles( a, b ) {
  7. ISSUE: line 1261 character 71: Use '!==' to compare with 'null'. - Evidence: display !== 'none' && display != null &&
  8. ISSUE: line 1403 character 55: Use '!==' to compare with 'null'. - Evidence: if ( !config || ImageAnnotator_config != null ) { return; }
  9. ISSUE: line 1419 character 62: Use '!==' to compare with 'null'. - Evidence: self.haveAjax = ( LAPI.Ajax.getRequest() != null );
  10. ISSUE: line 1867 character 29: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function get_size( info ) {
  11. ISSUE: line 1879 character 48: Use '!==' to compare with '0'. - Evidence: if ( i != 0 || !self.may_edit || !info.protection || mw.config.get( 'wgNamespaceNumber' ) != 6 ) { return; }
  12. ISSUE: line 2005 character 40: 'item' is already defined. - Evidence: for ( var item in self.defaults ) {
  13. ISSUE: line 2112 character 60: Use '!==' to compare with 'null'. - Evidence: IA.haveAjax = ( LAPI.Ajax.getRequest() != null );
  14. ISSUE: line 2232 character 21: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function track( evt ) {
  15. ISSUE: line 2259 character 21: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function pause( evt ) {
  16. ISSUE: line 2265 character 21: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function resume( evt ) {
  17. ISSUE: line 2275 character 21: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function stop_tracking( evt ) {
  18. ISSUE: line 2322 character 21: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function start_tracking( evt ) {
  19. ISSUE: line 2355 character 21: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function add_new( evt ) {
  20. ISSUE: line 2621 character 31: Don't make functions within a loop. - Evidence: } );
  21. ISSUE: line 3074 character 66: Use '!==' to compare with 'null'. - Evidence: self.haveAjax = ( LAPI.Ajax.getRequest() != null );

Your CommonsMaintenanceBot (talk) at 17:12, 26 September 2018 (UTC).

Return to the user page of "ESanders (WMF)".