Welcome to Wikimedia Commons, Ben79487!

-- Wikimedia Commons Welcome (talk) 02:33, 7 November 2018 (UTC)Reply

Categories edit

Hi. Just noting that you should probably create redlinked categories if they're linked from your new files (e.g. File:BSicon KXBHFe-R maroon.svg). Otherwise they don't show up in the BSicon category tree and eventually the file gets tagged as uncategorized. You could use pywikibot to create the categories, although the JavaScript version of AWB also works.

You can also recategorize BSicons or fix license tags by using find-and-replace in VisualFileChange, or by using pywikibot (or AWB, etc.). Jc86035 (talk) 18:09, 20 April 2019 (UTC)Reply

Hi! Just so you know, I'm quite busy right now, so in 6–8 (ish) hours I should be able to tinker with them. Thanks for letting me know! (P.S. The script which I put on BSicon/Guide was cobbled together a couple days ago.)  Ben79487 19:34, 20 April 2019 (UTC)Reply

The Python script edit

While I do think it's a better solution than the shell scripts, there are several issues which would prevent me from using it:

  • Presumably you've already fixed the title issue in your local version.
  • It doesn't create files in the u, f and g sets, or in the regular set. Those should usually be updated at the same time.
  • It's possible that the script itself is introducing the carriage return character (U+000D, CR, \r); I don't think it is but it would be better if the script automatically removed it. The character isn't necessary and adds several bytes to files; I've removed it from almost all of my uploads in the past two years.

Jc86035 (talk) 23:42, 20 April 2019 (UTC)Reply

Yes. I'll tinker with the local version, and will copy/paste it in the near future. I've fixed the title issue already, and will try to fix the u, f, regular, and g sets problem. However, I think that the carriage returns were present when I downloaded the files, and because the script is just performing a simple find-and-replace operation. Maybe I could code the script to remove it automatically?  
P.S. Good job on BSicon/Guide so far! Keep it up! – Ben79487 04:25, 22 April 2019 (UTC)Reply
Update: Have re-copied the script. Let me know if you think the .replace() chaining should be undoed, and also, do you know of a way to remove the spaces in between XML elements? (If I replace " " with "", then all the useful spaces, like the <path> spaces, get removed too, which breaks the SVG.)
I have also combined the _BLANK and the ex_BLANK, but haven't figured out how to do e_BLANK and x_BLANK. Suggestions are welcome!  Ben79487 05:03, 22 April 2019 (UTC)Reply
I think autofixes like the line break fixes (+ removing the last line break in the file, removing space before />) would be helpful.
It's much more difficult to do e and x icons unless they already exist in the input icon set, because this can vary dramatically between different icons, particularly if tunnel tracks are involved (e.g.   (ehkDST2) vs   (etKRZq3+1)). I probably wouldn't bother with it, although coding icon generation in general would be useful if it becomes desirable to create e.g. all of the possible crossing icons.
I'm not sure about the other issues. If you use regex you might be able to auto-format the indents (e.g. by counting how many unclosed elements there are before each line, and then removing/adding spaces accordingly – I think every SVG element does need to be closed but I'm not sure) and fix e.g. double line breaks and XML headers, which could be useful. Jc86035 (talk) 10:56, 23 April 2019 (UTC)Reply

Your new uploads edit

M375,500 v250 should be M375,500 V250. (The reason I specifically mention this is that your uploads with this specific code are visibly and obviously broken because the line is drawn outside the image frame.) Jc86035 (talk) 19:12, 27 April 2019 (UTC)Reply

Also, many of the elements you're using are unnecessary (particularly since you don't seem to be uploading any icons with mixed colours); for example, compare the two versions of   (uexvBHF-KBHFe). Jc86035 (talk) 19:15, 27 April 2019 (UTC)Reply

Yes Jc86035, I was also wondering why you are re-uploading so many existing icons, often with older and less-efficient code fragments. In addition, removing all the carriage returns between the <elements> makes it difficult to read (and edit) the code. Useddenim (talk) 21:40, 27 April 2019 (UTC)Reply

@Useddenim: I'll be reuploading these in a little bit. Jc86035 (talk) 10:21, 28 April 2019 (UTC)Reply
Done. Jc86035 (talk) 10:34, 28 April 2019 (UTC)Reply